[libcxx-commits] [PATCH] D124165: [libcxx][AIX] Enable ABI list checking for XCOFF

Fri Jun 10 19:16:08 PDT 2022

Jake-Egan added a comment.

In D124165#3573279 <https://reviews.llvm.org/D124165#3573279>, @ldionne wrote:

> In D124165#3475586 <https://reviews.llvm.org/D124165#3475586>, @daltenty wrote:
>
>> @ldionne It's worth noting what's in this patch right now won't be our final ABI lists unfortunately. Our build compiler currently doesn't implement visibility support, so `_LIBCPP_HIDE_FROM_ABI` and friends don't have the intended effect.  We're actively working on visibility for LLVM 15, but until that is all in we won't have a build compiler that can generate a stable ABI.
>>
>> What's your preference for how we should handle this? If you're ok with a bit of churn in the lists till we stabilize I think this can land as is. If not we could potentially use a development clang for the CI with ABI checks on (once that's available).
>
> Sorry, I missed that. But yes, I think it's OK to adjust the ABI lists afterwards. Let's land this.

If we could get D127470 <https://reviews.llvm.org/D127470> landed first, then we won't have to adjust the ABI list after.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124165/new/

https://reviews.llvm.org/D124165