[libcxx-commits] [PATCH] D127226: [libc++] Simplify type_traits and use more builtins

Fri Jun 10 16:18:58 PDT 2022

philnik added a comment.

In D127226#3574967 <https://reviews.llvm.org/D127226#3574967>, @alanphipps wrote:

> Hello! I'm noticing test failures with our downstream Arm compiler that may be related to the changes you're making, but I'm not sure where to begin looking.
>
> I'm seeing the following error:
>
>   ./include/c++/v1/__functional/invoke.h:14:10: fatal error: '__type_traits/add_lvalue_reference.h' file not found
>   #include <__type_traits/add_lvalue_reference.h>
>            ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>
> Did something happen to how add_lvalue_reference.h is installed?  Looks like there were changes to the modulemap. Thanks for your help.

`add_lvalue_reference` has been added in D126244 <https://reviews.llvm.org/D126244>, but I don't think there is anything different from the other granularization patches. Did anything fail like this before?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127226/new/

https://reviews.llvm.org/D127226