[libcxx-commits] [PATCH] D127489: [libc++] Use the same implementation of invoke for C++03 and C++11

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Fri Jun 10 08:49:02 PDT 2022


ldionne accepted this revision.
ldionne added a comment.
This revision is now accepted and ready to land.

The price to pay is a decrease in legibility of the main implementation of `std::__invoke`, however the benefit is really worth it IMO, so I'm happy with this.

Can you please check whether we have tests that could be expanded in C++03 now? I seem to recall seeing tests for `invoke` that wouldn't go beyond 3 arguments in C++03 mode or something like that, and they could be updated. The same should apply to `mem_fn` and `reference_wrapper`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127489/new/

https://reviews.llvm.org/D127489



More information about the libcxx-commits mailing list