[libcxx-commits] [PATCH] D127226: [libc++] Simplify type_traits and use more builtins

[Louis Dionne via Phabricator via libcxx-commits]

ldionne accepted this revision.
ldionne added a comment.
This revision is now accepted and ready to land.

LGTM, but can you please rebase to poke CI and get it green? I'd like to see this pass on all the compilers + platforms we have.



================
Comment at: libcxx/include/__type_traits/is_arithmetic.h:23
 
+#if __has_keyword(__is_arithmetic)
+
----------------
philnik wrote:
> ldionne wrote:
> > On what compilers is this not supported?
> In all cases GCC. Should I guard them with `#ifndef _LIBCPP_COMPILER_GCC`?
No, I guess it's OK to keep it as-is.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127226/new/

https://reviews.llvm.org/D127226