[libcxx-commits] [PATCH] D127387: [libc++] Implement P0174R2 (Deprecating Vestigial Library Parts in C++17)

[Louis Dionne via Phabricator via libcxx-commits]

ldionne accepted this revision.
ldionne added a subscriber: jwakely.
ldionne added a comment.
This revision is now accepted and ready to land.

LGTM without the `allocator<void>` part (and with passing CI).



================
Comment at: libcxx/include/__memory/allocator.h:32
 template <>
-class _LIBCPP_TEMPLATE_VIS allocator<void>
+class _LIBCPP_TEMPLATE_VIS _LIBCPP_DEPRECATED_IN_CXX17 allocator<void>
 {
----------------
There's a bit of history behind this, but TLDR, I don't think we want to do this part: https://reviews.llvm.org/D104323.

In particular, I think reading https://github.com/llvm/llvm-project/issues/49643 by @jwakely is relevant.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127387/new/

https://reviews.llvm.org/D127387