[libcxx-commits] [PATCH] D127313: [libc++] Implement P0618R0 (Deprecating <codecvt>)

[Louis Dionne via Phabricator via libcxx-commits]

ldionne accepted this revision.
ldionne added a comment.
This revision is now accepted and ready to land.

LGTM with changes applied and passing CI.



================
Comment at: libcxx/docs/ReleaseNotes.rst:149-152
+- The contents of ``<codecvt>``, ``wstring_convert`` and ``wbuffer_convert`` have been marked as deprecated.
+  To disable deprecation warnings you have to define ``_LIBCPP_DISABLE_DEPRECATION_WARNINGS``. Note that this
+  disables all deprecation warnings.
+
----------------
This should be under `API Changes`, not `ABI Changes`


================
Comment at: libcxx/include/codecvt:266-267
     unsigned long _Maxcode_;
+_LIBCPP_DIAGNOSTIC_PUSH
+_LIBCPP_CLANG_DIAGNOSTIC_IGNORED("-Wdeprecated-declarations")
     codecvt_mode _Mode_;
----------------
Here and elsewhere, let's use `_LIBCPP_SUPPRESS_DEPRECATED_PUSH` and `_LIBCPP_SUPPRESS_DEPRECATED_POP` instead.


================
Comment at: libcxx/src/locale.cpp:1834-1835
 
+_LIBCPP_DIAGNOSTIC_PUSH
+_LIBCPP_CLANG_DIAGNOSTIC_IGNORED("-Wdeprecated-declarations")
 static
----------------
`_LIBCPP_SUPPRESS_DEPRECATED_PUSH`


================
Comment at: libcxx/test/std/localization/locales/locale.convenience/conversions/conversions.buffer/depr.verify.cpp:8
 //===----------------------------------------------------------------------===//
 
+// UNSUPPORTED: c++03, c++11, c++14
----------------
I think you'll need to handle `no-localization` and `no-wide-characters` here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127313/new/

https://reviews.llvm.org/D127313