[libcxx-commits] [PATCH] D127132: [libc++] Remove _LIBCPP_PREFERRED_ALIGNOF

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Thu Jun 9 09:25:25 PDT 2022


ldionne requested changes to this revision.
ldionne added a comment.
This revision now requires changes to proceed.

I looked at https://reviews.llvm.org/D54814 again, and I think we should actually keep this, even if we end up defining `alignof` as a macro. Sorry for mis-leading you in my previous comment on D126249 <https://reviews.llvm.org/D126249>. I think it's too important to retain the notion that `__alignof` is the *preferred* alignment of the compiler in the name that we use, not only as a comment.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127132/new/

https://reviews.llvm.org/D127132



More information about the libcxx-commits mailing list