[libcxx-commits] [PATCH] D127325: Restore missing runtimes-test-depends target that causes build failures when LLVM_INCLUDE_TESTS is ON

[James Nagurne via Phabricator via libcxx-commits]

JamesNagurne added inline comments.


================
Comment at: runtimes/CMakeLists.txt:210
 if(LLVM_INCLUDE_TESTS)
+  add_custom_target(runtimes-test-depends ${LLVM_RUNTIMES_LIT_DEPENDS})
   # Add a global check rule now that all subdirectories have been traversed
----------------
ldionne wrote:
> I can't find any mention of `LLVM_RUNTIMES_LIT_DEPENDS` in the monorepo anymore, so this will always be an empty target. It may "fix" the build in that it won't complain about a missing target anymore, but it doesn't look correct to me. @phosek ?
This target is guaranteed by umbrella_lit_testsuite_begin

https://github.com/llvm/llvm-project/blob/4110c2c657b329f91a5c4eef653a15c1a15b61ed/llvm/cmake/modules/AddLLVM.cmake#L1888

I'm not a huge fan of relying on a variable that can't be easily searched, but this is the best facsimile of the original variable that was used as runtimes-test-depends' dependencies


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127325/new/

https://reviews.llvm.org/D127325