[libcxx-commits] [PATCH] D127257: [libcxx] improve LIBCXX_ABI_NAMESPACE error message

Florian Mayer via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Thu Jun 9 08:50:10 PDT 2022


fmayer added inline comments.


================
Comment at: libcxx/CMakeLists.txt:190
 if (NOT LIBCXX_ABI_NAMESPACE MATCHES "__.*")
-  message(FATAL_ERROR "LIBCXX_ABI_NAMESPACE must be a reserved identifier.")
+  message(FATAL_ERROR "LIBCXX_ABI_NAMESPACE must be a reserved identifier, is '${LIBCXX_ABI_NAMESPACE}'.")
 endif()
----------------
ldionne wrote:
> 
Ah sorry, I missed this. Submitted rG4110c2c657b329f91a5c4eef653a15c1a15b61ed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127257/new/

https://reviews.llvm.org/D127257



More information about the libcxx-commits mailing list