[libcxx-commits] [libcxx] d7e438c - [libcxx] improve LIBCXX_ABI_NAMESPACE error message

Florian Mayer via libcxx-commits libcxx-commits at lists.llvm.org
Thu Jun 9 08:48:01 PDT 2022


Author: Florian Mayer
Date: 2022-06-09T08:47:51-07:00
New Revision: d7e438c016e5f67113119a00d0fdf17d040ae26a

URL: https://github.com/llvm/llvm-project/commit/d7e438c016e5f67113119a00d0fdf17d040ae26a
DIFF: https://github.com/llvm/llvm-project/commit/d7e438c016e5f67113119a00d0fdf17d040ae26a.diff

LOG: [libcxx] improve LIBCXX_ABI_NAMESPACE error message

include the invalid LIBCXX_ABI_NAMESPACE to ease debugging.

Reviewed By: #libc, jloser, ldionne

Differential Revision: https://reviews.llvm.org/D127257

Added: 
    

Modified: 
    libcxx/CMakeLists.txt

Removed: 
    


################################################################################
diff  --git a/libcxx/CMakeLists.txt b/libcxx/CMakeLists.txt
index 829e414103e8..7a8ad2d69b4a 100644
--- a/libcxx/CMakeLists.txt
+++ b/libcxx/CMakeLists.txt
@@ -187,7 +187,7 @@ set(LIBCXX_LIBRARY_VERSION "${LIBCXX_ABI_VERSION}.0" CACHE STRING
    this also controls the linker's 'current_version' property.")
 set(LIBCXX_ABI_NAMESPACE "__${LIBCXX_ABI_VERSION}" CACHE STRING "The inline ABI namespace used by libc++. It defaults to __n where `n` is the current ABI version.")
 if (NOT LIBCXX_ABI_NAMESPACE MATCHES "__.*")
-  message(FATAL_ERROR "LIBCXX_ABI_NAMESPACE must be a reserved identifier.")
+  message(FATAL_ERROR "LIBCXX_ABI_NAMESPACE must be a reserved identifier, is '${LIBCXX_ABI_NAMESPACE}'.")
 endif()
 option(LIBCXX_ABI_FORCE_ITANIUM "Ignore auto-detection and force use of the Itanium ABI.")
 option(LIBCXX_ABI_FORCE_MICROSOFT "Ignore auto-detection and force use of the Microsoft ABI.")


        


More information about the libcxx-commits mailing list