[libcxx-commits] [PATCH] D127356: [libc++] Use __debug_iterator instead of const_iterator to interact with the debug mode

Thu Jun 9 06:00:57 PDT 2022

ldionne added a comment.

In D127356#3568390 <https://reviews.llvm.org/D127356#3568390>, @philnik wrote:

> How would it be useful? AFAICT you're not using `__debug_iterator` outside the class anywhere. Right now this only adds an indirection where none is needed.

As I mention in the review summary, it's useful e.g. for `std::span`, which doesn't have `const_iterator`. I uploaded DD127401 to show the follow-up.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127356/new/

https://reviews.llvm.org/D127356