[libcxx-commits] [PATCH] D127360: [libc++] Drop the legacy debug mode symbols by default

Thu Jun 9 05:56:13 PDT 2022

ldionne added a comment.

In D127360#3568495 <https://reviews.llvm.org/D127360#3568495>, @philnik wrote:

> I'm kind-of fearing that there are some applications out there that depend on the debug symbols in their release build somehow. I'm not sure if we want to break them, but that's not my call to make, so I'm fine with this.

Right -- this is why this is an ABI-breaking change, actually. I know this isn't a problem for Apple because we've never shipped those debug mode symbols, however it could potentially be for other vendors. That's why I'm adding libc++ vendors to the review -- it would be great if they could take a look in their ecosystem and see if applications are depending on those symbols (I know not all vendors have the capability to do that, but some do have at least a partial view of their ecosystems).

The main reason for this patch goes beyond simple cleanup -- the implementation of the debug mode itself is going to change in ways that are ABI breaking as well, so if we keep this around, it would become stale and out-of-sync with the rest of the debug mode. I'm thinking that we can try making this change, and if vendors encounter significant issues (most likely during qualification of LLVM 15), we can easily flip the switch back to `ON` by default.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127360/new/

https://reviews.llvm.org/D127360