[libcxx-commits] [PATCH] D103960: [libc++] Towards a simpler extern template story in libc++

Wed Jun 8 19:04:47 PDT 2022

ldionne accepted this revision as: libc++, libc++abi.
ldionne added a comment.
This revision is now accepted and ready to land.

In D103960#3567171 <https://reviews.llvm.org/D103960#3567171>, @philnik wrote:

> I really like this. I've got just one question: Why are the `extern` declarations for string different than for every other `extern template` class declaration?

Do you mean why do we use macros for them? It's just that there's a really long list of methods to declare, so using macros avoids repeating them. However, TBH it's not clear to me that it's actually better, since this sort of duplication isn't super harmful anyways. I think I'd be OK with changing that and repeating the list of instantiated methods in a separate patch.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103960/new/

https://reviews.llvm.org/D103960