[libcxx-commits] [PATCH] D127049: [libc++] Unwrap reverse_iterator<reverse_iterator<Iter>> in __unwrap_iter

Nikolas Klauser via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Wed Jun 8 14:05:56 PDT 2022


philnik added inline comments.


================
Comment at: libcxx/test/libcxx/algorithms/unwrap_iter.compile.pass.cpp:14
+#include <algorithm>
+#include <type_traits>
+
----------------
Mordante wrote:
> I would like to see some additional tests using Standard containers that use wrapped iterator.
> 
> I also would like to see some runtime tests for these containers verifying the result has the expected value. The copy test above only test with an array.
What is the difference between the first and the second request?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127049/new/

https://reviews.llvm.org/D127049



More information about the libcxx-commits mailing list