[libcxx-commits] [PATCH] D121530: [libc++][format] Implement format-string.
Mark de Wever via Phabricator via libcxx-commits
libcxx-commits at lists.llvm.org
Wed Jun 8 12:20:48 PDT 2022
Mordante marked an inline comment as done.
Mordante added inline comments.
Comment at: libcxx/benchmarks/formatter_float.bench.cpp:237
+ std::array<char, s> r;
+ std::ranges::copy(make_fmt(), r.begin());
+ return r;
> nit: no need to call make_fmt twice. In fact you could probably merge make_fmt into this lambda.
I tried that, but that doesn't seem to work. The `std::string` isn't a constexpr then.
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
More information about the libcxx-commits