[libcxx-commits] [PATCH] D127325: Restore missing runtimes-test-depends target that causes build failures when LLVM_INCLUDE_TESTS is ON

James Nagurne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Wed Jun 8 10:54:51 PDT 2022

JamesNagurne created this revision.
JamesNagurne added reviewers: sammccall, phosek.
Herald added a subscriber: mgorny.
Herald added a project: All.
JamesNagurne requested review of this revision.
Herald added projects: libc++, libc++abi.
Herald added a subscriber: libcxx-commits.
Herald added a reviewer: libc++.
Herald added a reviewer: libc++abi.

  Monorepo commit 7cc8377f, revision D121838 removed the 'runtimes-test-depends' target in runtimes builds that
  is assumed to exist when using a bootstrapped runtime build.
  For a full analysis, see:
  The solution here is presented mostly as a stop-gap to get discussion
  started, since contacting through Phabricator or Discourse have resulted
  in no response.
  A true solution would be to determine if runtimes-test-depends still makes
  sense and, if not, remove it from the bootstrap runtimes CMakeLists.

  rG LLVM Github Monorepo



Index: runtimes/CMakeLists.txt
--- runtimes/CMakeLists.txt
+++ runtimes/CMakeLists.txt
@@ -207,6 +207,7 @@
+  add_custom_target(runtimes-test-depends ${LLVM_RUNTIMES_LIT_DEPENDS})
   # Add a global check rule now that all subdirectories have been traversed
   # and we know the total set of lit testsuites.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D127325.435250.patch
Type: text/x-patch
Size: 461 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20220608/598b23bd/attachment.bin>

More information about the libcxx-commits mailing list