[libcxx-commits] [PATCH] D127257: [libcxx] improve LIBCXX_ABI_NAMESPACE error message

[Florian Mayer via Phabricator via libcxx-commits]

fmayer created this revision.
Herald added a subscriber: mgorny.
Herald added a project: All.
fmayer requested review of this revision.
Herald added a project: libc++.
Herald added a subscriber: libcxx-commits.
Herald added a reviewer: libc++.

include the invalid LIBCXX_ABI_NAMESPACE to ease debugging.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D127257

Files:
  libcxx/CMakeLists.txt


Index: libcxx/CMakeLists.txt
===================================================================
--- libcxx/CMakeLists.txt
+++ libcxx/CMakeLists.txt
@@ -187,7 +187,7 @@
    this also controls the linker's 'current_version' property.")
 set(LIBCXX_ABI_NAMESPACE "__${LIBCXX_ABI_VERSION}" CACHE STRING "The inline ABI namespace used by libc++. It defaults to __n where `n` is the current ABI version.")
 if (NOT LIBCXX_ABI_NAMESPACE MATCHES "__.*")
-  message(FATAL_ERROR "LIBCXX_ABI_NAMESPACE must be a reserved identifier.")
+  message(FATAL_ERROR "LIBCXX_ABI_NAMESPACE must be a reserved identifier, is \"${LIBCXX_ABI_NAMESPACE}\".")
 endif()
 option(LIBCXX_ABI_FORCE_ITANIUM "Ignore auto-detection and force use of the Itanium ABI.")
 option(LIBCXX_ABI_FORCE_MICROSOFT "Ignore auto-detection and force use of the Microsoft ABI.")


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D127257.434970.patch
Type: text/x-patch
Size: 832 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20220607/d7fede52/attachment.bin>