[libcxx-commits] [PATCH] D121530: [libc++][format] Implement format-string.

[Mark de Wever via Phabricator via libcxx-commits]

Mordante marked 6 inline comments as done.
Mordante added a comment.

Thanks for the review!



================
Comment at: libcxx/include/format:488-490
+    array<__arg_t, sizeof...(_Args)> __result;
+    __arg_t* __types = __result.data();
+    ([&] { *__types++ = __determine_arg_t<_Context, _Args>(); }(), ...);
----------------
ldionne wrote:
> Would this work too? If so, it may even become unnecessary to have a `__get_types` function altogether, perhaps we can just inline it in the body of `__basic_format_string` below.
Thanks for the suggestion, that removes quite some unneeded lines, especially for `__get_handle`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121530/new/

https://reviews.llvm.org/D121530