[libcxx-commits] [PATCH] D127033: [libc++] Define ostream nullptr inserter for >= C++17 only
Zhihao Yuan via Phabricator via libcxx-commits
libcxx-commits at lists.llvm.org
Tue Jun 7 10:24:09 PDT 2022
lichray added a comment.
In D127033#3563576 <https://reviews.llvm.org/D127033#3563576>, @jwakely wrote:
> Also, Billy O'Neal reported that the new overload caused ambiguities for some morally questionable code in Google Test, which was trying to define it's own overload for this type. Breaking existing code (even if it's bad code) is another reason to not enable it unconditionally. I guess that's no longer an issue, or somebody would have noticed it when using gtest and libc++!
> It seems like the only known uses for this `operator<<` are in Boost.Test, Google Test, and Mozilla's assertion macros ... so I super don't care about it.
I filed https://github.com/llvm/llvm-project/issues/55861 because of a breakage found in Symantec's test code. I'm requesting the new overload *not* be added to old versions of C++, for portability's sake.
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
More information about the libcxx-commits