[libcxx-commits] [PATCH] D124346: [libc++] Complete the implementation of N4190

[Nikolas Klauser via Phabricator via libcxx-commits]

philnik added inline comments.


================
Comment at: libcxx/include/__functional/mem_fn.h:43-45
+#if _LIBCPP_STD_VER > 14
+    typename invoke_result<type, _ArgTypes...>::type
+#else
----------------
ldionne wrote:
> Why is this needed?
I can't remember why I added it and everything works without it, so I removed it.


================
Comment at: libcxx/include/__functional/weak_result_type.h:232
 
 #ifndef _LIBCPP_CXX03_LANG
 // 3 or more arguments
----------------
ldionne wrote:
> Something for a different patch, but we do support variadics in C++03 so we can include this code block in all cases, unless I am mistaken.
Added a TODO.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124346/new/

https://reviews.llvm.org/D124346