[libcxx-commits] [PATCH] D126610: [libc++] Implement ranges::adjacent_find

Nikolas Klauser via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Mon Jun 6 05:15:57 PDT 2022


philnik added inline comments.


================
Comment at: libcxx/include/__type_traits/enable_if.h:13
 #include <__config>
-#include <cstddef>
 
----------------
Mordante wrote:
> This seems unrelated, please commit it separately.
This was part of D126469. I don't know why it was part of this diff.


================
Comment at: libcxx/test/std/algorithms/alg.nonmodifying/alg.adjacent.find/ranges.adjacent_find.pass.cpp:77
+  // simple test
+  test<Iter, Sent, 4>({.input = {1, 2, 2, 4}, .expected = 1});
+  // last is returned with no match
----------------
Mordante wrote:
> Can't `N` be deduced?
I don't think so. @var-const and I also thought it could be deduced, but I couldn't get it to work.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126610/new/

https://reviews.llvm.org/D126610



More information about the libcxx-commits mailing list