[libcxx-commits] [PATCH] D126868: [libunwind] Remove unused ARM SEH placeholder code

Martin Storsjö via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Sun Jun 5 13:38:55 PDT 2022


mstorsjo added a comment.

In D126868#3559208 <https://reviews.llvm.org/D126868#3559208>, @manojgupta wrote:

> Daniel, can you please check if this removal is ok. I am particularly worried about pthread_cancel which is often hard to debug.

What does this code have to do with `pthread_cancel`? This code in libunwind is for the specific combination of `defined(__SEH__) && defined(__arm__)`; no LLVM compiler has ever produced that combination yet, but once all these pieces are in place, I'll switch the clang mingw arm target to take SEH into use (and start defining that combination).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126868/new/

https://reviews.llvm.org/D126868



More information about the libcxx-commits mailing list