[libcxx-commits] [PATCH] D126610: [libc++] Implement ranges::adjacent_find

[Mark de Wever via Phabricator via libcxx-commits]

Mordante added a comment.

For the most part LGTM except for some minor issues.



================
Comment at: libcxx/include/__type_traits/enable_if.h:13
 #include <__config>
-#include <cstddef>
 
----------------
This seems unrelated, please commit it separately.


================
Comment at: libcxx/test/std/algorithms/alg.nonmodifying/alg.adjacent.find/ranges.adjacent_find.pass.cpp:77
+  // simple test
+  test<Iter, Sent, 4>({.input = {1, 2, 2, 4}, .expected = 1});
+  // last is returned with no match
----------------
Can't `N` be deduced?


================
Comment at: libcxx/test/std/algorithms/alg.nonmodifying/alg.adjacent.find/ranges.adjacent_find.pass.cpp:105
+
+  { // check that the complexity requirements are met
+    {
----------------
Please also test the complexity when a match is found.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126610/new/

https://reviews.llvm.org/D126610