[libcxx-commits] [PATCH] D127051: [libc++][test] Mark ranges.transform.pass.cpp XFAIL for AIX

[Nikolas Klauser via Phabricator via libcxx-commits]

philnik added subscribers: DanielMcIntosh-IBM, SeanP, daltenty.
philnik added a comment.

In D127051#3558538 <https://reviews.llvm.org/D127051#3558538>, @jloser wrote:

> In D127051#3558524 <https://reviews.llvm.org/D127051#3558524>, @philnik wrote:
>
>> The test is just long. So either the test should be made shorted somehow or the timeout for AIX should be longer. XFAILing it doesn't solve the problem in any way. It's just the 50/50 chance of passing reversed to a 50/50 chance of failing.
>
> I see. So, we could bump the timeout set by `run-buildbot` to bump it up from the current `1200` seconds, but that's awfully high already. Have you already looked into why it's taking so long (and only on AIX?)?  Is it spending so much time compiling (can look with `-ftime-trace` and `ClangBuildAnalyzer`), or something else?

The test always takes a long time to run. On my machine it's 47 seconds. I think the average test takes more like one to two seconds. The problem is that we instantiate the actual test with 7 * 7 * 7 ( = 343) iterator combinations. I don't know why it takes twenty minutes on AIX though. I guess something isn't well optimized in the compiler and that gets multiplied 343 times. That's probably something someone from AIX should look into. @DanielMcIntosh-IBM @SeanP @daltenty


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127051/new/

https://reviews.llvm.org/D127051