[libcxx-commits] [PATCH] D126882: [libc++] Do not yield from __sp_mut::lock()

[Dimitry Andric via Phabricator via libcxx-commits]

dim added a comment.

In D126882#3553338 <https://reviews.llvm.org/D126882#3553338>, @ldionne wrote:

> This patch was put together in collaboration with a performance engineer on our side. It was tested with a use case that was previously problematic and this patch did solve the issue. We believe this should be an improvement for all OSes if their `pthread_mutex_lock` is reasonable (which is the case on Linux and Apple at least)

What would you consider "reasonable"? Or maybe I should ask the question differently: what was the original reason for adding the while loop in the first place?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126882/new/

https://reviews.llvm.org/D126882