[libcxx-commits] [PATCH] D122941: [libc++] Make the Debug mode a configuration-time only option

[Nikolas Klauser via Phabricator via libcxx-commits]

philnik added inline comments.


================
Comment at: libcxx/CMakeLists.txt:76-80
+option(LIBCXX_ENABLE_BACKWARDS_COMPATIBILITY_DEBUG_MODE_SYMBOLS
+   "Whether to include the old Debug mode symbols in the compiled library. This
+    is provided for backwards compatibility since the compiled library used to
+    always contain those symbols, regardless of whether the library was built
+    with the debug mode enabled." ON)
----------------
Could we disable this by default in the unstable ABI?


================
Comment at: libcxx/docs/DesignDocs/DebugMode.rst:25
+enabled -- we reserve the right to change the ABI at any time. If you need a stable ABI
+and still want some level of hardenning, you should look into enabling :ref:`assertions <assertions-mode>`
+instead.
----------------



================
Comment at: libcxx/include/__debug:38
+      if (!__builtin_is_constant_evaluated())                                                                   \
+        _VSTD::shuffle(__first, __last, __libcpp_debug_randomizer());                                           \
+    } while (false)
----------------



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122941/new/

https://reviews.llvm.org/D122941