[libcxx-commits] [PATCH] D122941: [libc++] Make the Debug mode a configuration-time only option

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Fri Jun 3 12:48:40 PDT 2022


ldionne added a comment.

In D122941#3425163 <https://reviews.llvm.org/D122941#3425163>, @danlark wrote:

> Hmm, from the exact snapshot of the patch I see that `_LIBCPP_DEBUG_RANDOMIZE_UNSPECIFIED_STABILITY` can be used as a build flag without `LIBCXX_ENABLE_DEBUG_MODE=on`, is this going to be changed?

Actually, you're right. That wasn't the intent of the patch originally, but it works and I agree it should have been the intent of the patch. My next update will reflect that intent, and will ensure that it's tested.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122941/new/

https://reviews.llvm.org/D122941



More information about the libcxx-commits mailing list