[libcxx-commits] [PATCH] D126738: [libc++][NFC] Inline the definition of ~basic_ios()

[Nikolas Klauser via Phabricator via libcxx-commits]

philnik added a comment.

In D126738#3556372 <https://reviews.llvm.org/D126738#3556372>, @EricWF wrote:

> In D126738#3550837 <https://reviews.llvm.org/D126738#3550837>, @ldionne wrote:
>
>> (requesting changes until I have more info)
>
> I would also like to ensure that we're not inlining the key function. It seems less than ideal to emit the vtable inline in every TU.

Is there a reason `-Wweak-vtables` isn't enabled?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126738/new/

https://reviews.llvm.org/D126738