[libcxx-commits] [PATCH] D126738: [libc++][NFC] Inline the definition of ~basic_ios()
Nikolas Klauser via Phabricator via libcxx-commits
libcxx-commits at lists.llvm.org
Fri Jun 3 10:41:12 PDT 2022
philnik added a comment.
In D126738#3556372 <https://reviews.llvm.org/D126738#3556372>, @EricWF wrote:
> In D126738#3550837 <https://reviews.llvm.org/D126738#3550837>, @ldionne wrote:
>> (requesting changes until I have more info)
> I would also like to ensure that we're not inlining the key function. It seems less than ideal to emit the vtable inline in every TU.
Is there a reason `-Wweak-vtables` isn't enabled?
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
More information about the libcxx-commits