[libcxx-commits] [PATCH] D126666: [libc++][CI] Updates Docker image.

Mark de Wever via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Fri Jun 3 09:06:03 PDT 2022

Mordante marked 3 inline comments as done.
Mordante added inline comments.

Comment at: libcxx/utils/ci/Dockerfile:59
 # We also install <latest-2> to allow smooth CI transitions around release points.
+# TODO enable LVM_LATEST_VERSION - 2 after changing to version 15
+# Normally this is enabled but LLVM 12 isn't backported to Jammy.
jloser wrote:
> `s/LVM/LLVM`, please.
Good catch, thanks. I'll update it before landing unless there are other review comments.

Comment at: libcxx/utils/ci/Dockerfile:64
 RUN wget https://apt.llvm.org/llvm.sh -O /tmp/llvm.sh
-RUN bash /tmp/llvm.sh $(($LLVM_LATEST_VERSION - 2)) # for CI transitions
+#RUN bash /tmp/llvm.sh $(($LLVM_LATEST_VERSION - 2)) # for CI transitions
 RUN bash /tmp/llvm.sh $(($LLVM_LATEST_VERSION - 1)) # previous release
ldionne wrote:
> As explained above, the problem with removing this line as-is is that it's going to break CI on `release/14.x`.
As discussed during the online review Ubuntu Jammy ships clang-12, so I'll use that.

  rG LLVM Github Monorepo



More information about the libcxx-commits mailing list