[libcxx-commits] [PATCH] D124328: [libc++] Forward more often to memmove in copy

Nikolas Klauser via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Fri Jun 3 03:50:55 PDT 2022


philnik added inline comments.


================
Comment at: libcxx/include/__algorithm/copy.h:113
+pair<reverse_iterator<reverse_iterator<_InIter> >, reverse_iterator<reverse_iterator<_OutIter> > >
+__copy_impl(reverse_iterator<reverse_iterator<_InIter> > __first,
+            reverse_iterator<reverse_iterator<_Sent> > __last,
----------------
ldionne wrote:
> I would like to investigate (in a different patch if the experiment turns out positive) the possibility of overloading `__unwrap_iter` (and `__rewrap_iter`) for `reverse_iterator<reverse_iterator<It>>` more generally. If that works out, we would get some added benefits in other algorithms as well for free, and this overload could go away entirely.
Added a TODO


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124328/new/

https://reviews.llvm.org/D124328



More information about the libcxx-commits mailing list