[libcxx-commits] [PATCH] D107799: [CMake] Enable LLVM_ENABLE_PER_TARGET_RUNTIME_DIR by default on Linux

Fri Jun 3 01:25:16 PDT 2022

mstorsjo added a comment.

In D107799#3555458 <https://reviews.llvm.org/D107799#3555458>, @MaskRay wrote:

> The runtime builds use `-DLLVM_ENABLE_PER_TARGET_RUNTIME_DIR=off`. 
> Non-runtime builds for libc++/libc++abi/libunwind have been deprecated (D112724 <https://reviews.llvm.org/D112724>).

This statement is a bit inaccurate. What you refer to as "runtime builds" can mean two different things:

- Pointing CMake at `<monorepo>/llvm` and including the runtimes with `-DLLVM_ENABLE_RUNTIMES` (so it builds llvm+clang and then uses the just-built clang to build the runtimes)
- Pointing CMake at `<monorepo/runtimes` and building libcxx/etc with any compiler you like (as long as it's new enough)

Both of them are still supported for libc++/libcxx+abi/libunwind. The former defaults to `LLVM_ENABLE_PER_TARGET_RUNTIME_DIR` on (as far as I know), the latter doesn't.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107799/new/

https://reviews.llvm.org/D107799