[libcxx-commits] [PATCH] D126850: [libc++][test] Skip string_view tests for other vendors on older modes

[Mark de Wever via Phabricator via libcxx-commits]

Mordante added a comment.

Thanks for the cleanup! There are several minor issues.



================
Comment at: libcxx/test/std/strings/string.view/string.view.cons/from_iterator_sentinel.pass.cpp:15
 
+// UNSUPPORTED: !stdlib=libc++ && (c++03 || c++11 || c++14)
+
----------------
This isn't needed, see line 8.


================
Comment at: libcxx/test/std/strings/string.view/string.view.cons/from_range.pass.cpp:16
 
+// UNSUPPORTED: !stdlib=libc++ && (c++03 || c++11 || c++14)
+
----------------
This isn't needed, see line 8.


================
Comment at: libcxx/test/std/strings/string.view/string.view.hash/string_view.pass.cpp:18
 
+// UNSUPPORTED: !stdlib=libc++ && (c++03 || c++11 || c++14)
+
----------------
Can you move this more to the top, (before `// <functional>`) of the file like we do in the other tests?

Same for other places.


================
Comment at: libcxx/test/std/strings/string.view/string.view.template/ends_with.ptr.pass.cpp:31
+    SV  sv4 { s + 1, 4 };
+    SV  sv5 { s    , 5 };
     SV  svNot {"def", 3 };
----------------
Is this intended? It adds new unused variables.

(This file contains a similar commented out block at line 71.)

The same for the next file.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126850/new/

https://reviews.llvm.org/D126850