[libcxx-commits] [PATCH] D126887: [libc++] Don't use static constexpr in headers.

Mark de Wever via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Thu Jun 2 08:27:08 PDT 2022


Mordante created this revision.
Herald added a project: All.
Mordante requested review of this revision.
Herald added a project: libc++.
Herald added a subscriber: libcxx-commits.
Herald added a reviewer: libc++.

This was noticed in the review of D125704 <https://reviews.llvm.org/D125704>. In that commit only the new
table has been adapted. This adapts the existing tables.

Note since libc++'s charconv is backported to C++11 it's not possible to
use inline constexpr variables. The were introduced in C++17.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D126887

Files:
  libcxx/include/__charconv/tables.h
  libcxx/include/__charconv/to_chars_base_10.h
  libcxx/include/charconv
  libcxx/src/include/ryu/digit_table.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D126887.433762.patch
Type: text/x-patch
Size: 15162 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20220602/b4837a07/attachment-0001.bin>


More information about the libcxx-commits mailing list