[libcxx-commits] [PATCH] D126823: [libc++] Support int8_t and uint8_t in integer distributions as an extension

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Thu Jun 2 07:40:47 PDT 2022


ldionne updated this revision to Diff 433749.
ldionne added a comment.

Fix documentation build. I think this is going to fail in two of the test's distributions because we apparently struggle to be as faithful for small types.

After a small investigation, I think this is because our poisson distribution isn't as good for types with fewer bits, but we'll have to figure that out before shipping the patch.

- Either we're OK with the distribution not being as faithful, and we relax the tests, or
- we find a way to improve the implementation for smaller types.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126823/new/

https://reviews.llvm.org/D126823

Files:
  libcxx/docs/ReleaseNotes.rst
  libcxx/docs/UsingLibcxx.rst
  libcxx/include/__random/binomial_distribution.h
  libcxx/include/__random/discrete_distribution.h
  libcxx/include/__random/geometric_distribution.h
  libcxx/include/__random/is_valid.h
  libcxx/include/__random/negative_binomial_distribution.h
  libcxx/include/__random/poisson_distribution.h
  libcxx/include/__random/uniform_int_distribution.h
  libcxx/test/std/numerics/rand/rand.dist/rand.dist.bern/rand.dist.bern.bin/eval.pass.cpp
  libcxx/test/std/numerics/rand/rand.dist/rand.dist.bern/rand.dist.bern.geo/eval.pass.cpp
  libcxx/test/std/numerics/rand/rand.dist/rand.dist.bern/rand.dist.bern.negbin/eval.pass.cpp
  libcxx/test/std/numerics/rand/rand.dist/rand.dist.pois/rand.dist.pois.poisson/eval.pass.cpp
  libcxx/test/std/numerics/rand/rand.dist/rand.dist.samp/rand.dist.samp.discrete/eval.pass.cpp
  libcxx/test/std/numerics/rand/rand.dist/rand.dist.uni/rand.dist.uni.int/eval.pass.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D126823.433749.patch
Type: text/x-patch
Size: 47229 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20220602/cddca6e3/attachment-0001.bin>


More information about the libcxx-commits mailing list