[libcxx-commits] [PATCH] D126868: [libunwind] Remove unused ARM SEH placeholder code

Martin Storsjö via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Thu Jun 2 02:38:27 PDT 2022


mstorsjo created this revision.
mstorsjo added reviewers: MaskRay, efriedma, zzheng, cdavis5x.
Herald added subscribers: StephenFan, kristof.beyls.
Herald added projects: libunwind, All.
Herald added a reviewer: libunwind.
mstorsjo requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

There's no such corresponding code for ARM64 (which has been working
in production for years). The SEH version of the Unwind functions
(e.g. `_Unwind_GetLanguageSpecificData`) doesn't use these fields.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D126868

Files:
  libunwind/src/UnwindCursor.hpp


Index: libunwind/src/UnwindCursor.hpp
===================================================================
--- libunwind/src/UnwindCursor.hpp
+++ libunwind/src/UnwindCursor.hpp
@@ -1965,10 +1965,6 @@
       _info.handler = 0;
     }
   }
-#elif defined(_LIBUNWIND_TARGET_ARM)
-  _info.end_ip = _info.start_ip + unwindEntry->FunctionLength;
-  _info.lsda = 0; // FIXME
-  _info.handler = 0; // FIXME
 #endif
   setLastPC(pc);
   return true;


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D126868.433700.patch
Type: text/x-patch
Size: 440 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20220602/16e5f705/attachment.bin>


More information about the libcxx-commits mailing list