[libcxx-commits] [PATCH] D126210: [libcxx] Fix allocator<void>::pointer in C++20 with removed members

[Ilya Biryukov via Phabricator via libcxx-commits]

ilya-biryukov added inline comments.


================
Comment at: libcxx/test/libcxx/utilities/memory/default.allocator/allocator_types.void.cxx20_allocator_void_no_members.fail.cpp:9-10
+
+// Check that the nested types of std::allocator<void> are provided in C++20
+// with a flag that keeps the removed members.
+
----------------
ldionne wrote:
> Can you explain what this test does? This sentence seems to be copy-pasted from the below test, but they are not checking the same thing.
It is copy-pasted indeed, thanks for catching that. I'll update the comment.
This test attempts to verify that the void specialization actually does not contain the removed members if the `_LIBCPP_ENABLE_CXX20_REMOVED_ALLOCATOR_MEMBERS` is not specified.



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126210/new/

https://reviews.llvm.org/D126210