[libcxx-commits] [PATCH] D126017: [libunwind][ci][AIX] Add libunwind to buildbot CI

[Xing Xue via Phabricator via libcxx-commits]

xingxue marked an inline comment as done.
xingxue added inline comments.


================
Comment at: libcxx/utils/ci/run-buildbot:603-609
     generate-cmake -C "${MONOREPO_ROOT}/libcxx/cmake/caches/AIX.cmake" \
                    -DLIBCXX_TEST_CONFIG="ibm-libc++-shared.cfg.in" \
                    -DLIBCXXABI_TEST_CONFIG="ibm-libc++abi-shared.cfg.in" \
-                   -DLLVM_ENABLE_RUNTIMES="libcxx;libcxxabi"
-    # TODO: use check-runtimes once libunwind builds cleanly on AIX.
-    ${NINJA} -vC "${BUILD_DIR}" install-cxx install-cxxabi
-    ${NINJA} -vC "${BUILD_DIR}" check-cxx check-cxxabi
+                   -DLIBUNWIND_TEST_CONFIG="ibm-libunwind-shared.cfg.in" \
+                   -DLLVM_ENABLE_RUNTIMES="libcxx;libcxxabi;libunwind"
+    ${NINJA} -vC "${BUILD_DIR}" install-cxx install-cxxabi install-unwind
+    check-runtimes
----------------
ldionne wrote:
> This can now become simply:
> 
> ```
> generate-cmake -C "${MONOREPO_ROOT}/libcxx/cmake/caches/AIX.cmake" \
>                    -DLIBCXX_TEST_CONFIG="ibm-libc++-shared.cfg.in" \
>                    -DLIBCXXABI_TEST_CONFIG="ibm-libc++abi-shared.cfg.in" \
>                    -DLIBUNWIND_TEST_CONFIG="ibm-libunwind-shared.cfg.in"
> check-runtimes
> ```
> 
Changed as suggested, thanks!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126017/new/

https://reviews.llvm.org/D126017