[libcxx-commits] [PATCH] D125745: [libc++] Removes _LIBCPP_AVAILABILITY_TO_CHARS.

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Wed Jun 1 10:45:15 PDT 2022


ldionne accepted this revision.
ldionne added a comment.
This revision is now accepted and ready to land.

LGTM.

Can we add a release note to mention that `to_chars` doesn't have a minimum deployment target anymore? It's something useful for folks to know.



================
Comment at: libcxx/test/std/utilities/charconv/charconv.from.chars/integral.roundtrip.pass.cpp:13-14
 
 // The roundtrip test uses to_chars, which requires functions in the dylib
 // that were introduced in Mac OS 10.15.
 
----------------
This should be removed too!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125745/new/

https://reviews.llvm.org/D125745



More information about the libcxx-commits mailing list