[libcxx-commits] [PATCH] D126737: [libc++][test] Enable constexpr string comparison tests

Wed Jun 1 10:19:14 PDT 2022

philnik added a comment.

The `ranges::transform` test timeouts are normal. You can consider the CI passed.

================
Comment at: libcxx/test/std/strings/string.view/string.view.comparison/equal.pass.cpp:10
 // <string_view>

 // template<class charT, class traits>
----------------
jloser wrote:
> philnik wrote:
> > jloser wrote:
> > > philnik wrote:
> > > > Pre-existing: These tests should only be enabled for libc++ pre-C++17.
> > > I don't think so, since we backport `string_view` all the way back to C++03 as an extension.
> > Sorry, my comment was a bit unclear: It should only be enabled //for libc++// pre-C++17. i.e. not for libstdc++, MSVC STL etc. I'm not 100% sure, but I think `// UNSUPPORTED: !stdlib=libc++ && (c++03 || c++11 || c++14)` should work.
> I see. Yeah, I agree with that. That's a pre-existing thing though and I'd recommend we do that for all of the `string_view` tests. I'm happy to volunteer to do that as a follow-up if that works for you.
Ok yeah. If they are missing for all tests it should probably be done in a separate PR.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126737/new/

https://reviews.llvm.org/D126737