[libcxx-commits] [PATCH] D126737: [libc++][test] Enable constexpr string comparison tests

[Nikolas Klauser via Phabricator via libcxx-commits]

philnik accepted this revision.
philnik added a comment.
This revision is now accepted and ready to land.

LGTM assuming CI passes. It would be nice if you could disable the tests for other standard libraries pre-C++17.



================
Comment at: libcxx/test/std/strings/string.view/string.view.comparison/equal.pass.cpp:10
 // <string_view>
 
 // template<class charT, class traits>
----------------
jloser wrote:
> philnik wrote:
> > Pre-existing: These tests should only be enabled for libc++ pre-C++17.
> I don't think so, since we backport `string_view` all the way back to C++03 as an extension.
Sorry, my comment was a bit unclear: It should only be enabled //for libc++// pre-C++17. i.e. not for libstdc++, MSVC STL etc. I'm not 100% sure, but I think `// UNSUPPORTED: !stdlib=libc++ && (c++03 || c++11 || c++14)` should work.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126737/new/

https://reviews.llvm.org/D126737