[libcxx-commits] [PATCH] D125610: [NFC][libc++][format] Improves naming.
Mark de Wever via Phabricator via libcxx-commits
libcxx-commits at lists.llvm.org
Wed Jun 1 08:54:38 PDT 2022
Mordante marked an inline comment as done.
Mordante added inline comments.
Comment at: libcxx/include/__format/buffer.h:105
static constexpr size_t __buffer_size_ = 256 / sizeof(_CharT);
> Should we expose a public `static size_t __buffer_size()` method instead? Otherwise we could also drop the trailing underscore from `__buffer_size_`, which makes it look like a data member, and use `__buffer_size` directly. No strong opinion.
I have a slight preference to use a static data member, I'll drop the trailing underscore.
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
More information about the libcxx-commits