[libcxx-commits] [PATCH] D125610: [NFC][libc++][format] Improves naming.

[Mark de Wever via Phabricator via libcxx-commits]

Mordante marked an inline comment as done.
Mordante added inline comments.


================
Comment at: libcxx/include/__format/buffer.h:105
 
-private:
   static constexpr size_t __buffer_size_ = 256 / sizeof(_CharT);
+
----------------
ldionne wrote:
> Should we expose a public `static size_t __buffer_size()` method instead? Otherwise we could also drop the trailing underscore from `__buffer_size_`, which makes it look like a data member, and use `__buffer_size` directly. No strong opinion.
I have a slight preference to use a static data member, I'll drop the trailing underscore.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125610/new/

https://reviews.llvm.org/D125610