[libcxx-commits] [PATCH] D126737: [libc++][test] Enable constexpr string comparison tests

Joe Loser via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Wed Jun 1 07:23:24 PDT 2022


jloser added inline comments.


================
Comment at: libcxx/test/std/strings/string.view/string.view.comparison/equal.pass.cpp:10
 // <string_view>
 
 // template<class charT, class traits>
----------------
philnik wrote:
> Pre-existing: These tests should only be enabled for libc++ pre-C++17.
I don't think so, since we backport `string_view` all the way back to C++03 as an extension.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126737/new/

https://reviews.llvm.org/D126737



More information about the libcxx-commits mailing list