[libcxx-commits] [PATCH] D130854: [libc++][NFC] Qualify declaval

Sun Jul 31 12:56:19 PDT 2022

philnik created this revision.
philnik added reviewers: ldionne, Mordante, var-const.
Herald added a project: All.
philnik requested review of this revision.
Herald added a project: libc++.
Herald added a subscriber: libcxx-commits.
Herald added a reviewer: libc++.

While it's not necessary to qualify calls to `declval` it makes error messages very crypric if the declaration isn't reachable anymore

Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D130854

Files:
  libcxx/include/__concepts/common_with.h
  libcxx/include/__concepts/convertible_to.h
  libcxx/include/__functional/invoke.h
  libcxx/include/__functional/reference_wrapper.h
  libcxx/include/__functional/weak_result_type.h
  libcxx/include/__iterator/advance.h
  libcxx/include/__iterator/incrementable_traits.h
  libcxx/include/__iterator/move_iterator.h
  libcxx/include/__memory/allocator_traits.h
  libcxx/include/__memory/construct_at.h
  libcxx/include/__memory/ranges_construct_at.h
  libcxx/include/__memory/shared_ptr.h
  libcxx/include/__ranges/all.h
  libcxx/include/__ranges/ref_view.h
  libcxx/include/__ranges/size.h
  libcxx/include/__type_traits/common_type.h
  libcxx/include/__type_traits/is_assignable.h
  libcxx/include/__type_traits/is_convertible.h
  libcxx/include/__type_traits/is_nothrow_assignable.h
  libcxx/include/__type_traits/is_nothrow_constructible.h
  libcxx/include/__type_traits/is_nothrow_convertible.h
  libcxx/include/__type_traits/is_nothrow_destructible.h
  libcxx/include/__type_traits/promote.h
  libcxx/include/__utility/declval.h
  libcxx/include/istream
  libcxx/include/scoped_allocator
  libcxx/include/type_traits
  libcxx/include/variant

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D130854.448880.patch
Type: text/x-patch
Size: 20345 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20220731/5d77879f/attachment-0001.bin>