[libcxx-commits] [PATCH] D128146: [libc++] Use uninitialized algorithms for vector

Nico Weber via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Fri Jul 29 11:05:25 PDT 2022


thakis added a comment.

In D128146#3687957 <https://reviews.llvm.org/D128146#3687957>, @philnik wrote:

> @thakis I wouldn't say the change is intentional, but the change is definitely expected. Especially, since it looks like `-Wdeprecated-copy` is basically a rule-of-{0, 3, 5} warning, which you violated by having the copy constructor explicitly defaulted. Although I'm not sure why clang only warns when the constructor is used instead of when the class is declared.

Thanks for the reply!

As for the question, I'm guessing it's due to false positive rate of useful instances of the warning. Clang often warns on use instead of on declaration for that reason.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128146/new/

https://reviews.llvm.org/D128146



More information about the libcxx-commits mailing list