[libcxx-commits] [PATCH] D130785: [libc++] Implement P2499R0 (`string_view` range constructor should be `explicit`)

[Nikolas Klauser via Phabricator via libcxx-commits]

philnik accepted this revision.
philnik added a comment.
This revision is now accepted and ready to land.

LGTM % nits. Do you need someone to land it? If yes, please provide `"Your Name" <your at email.addres>`.



================
Comment at: libcxx/docs/ReleaseNotes.rst:40
 ------------------
+- Implemented P2499R0 (``string_view`` range constructor should be ``explicit``)
 
----------------



================
Comment at: libcxx/test/std/strings/string.view/string.view.cons/from_range.pass.cpp:189
 
+// P2499R0 string_view Range Constructor Should Be explicit
+static_assert(!std::is_convertible_v<std::vector<char>, std::string_view>);
----------------
I wouldn't bother saying which paper changed it. It's not like anybody will care when reading this later.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130785/new/

https://reviews.llvm.org/D130785