[libcxx-commits] [PATCH] D130562: [libc++] Rename __libcpp_assertion_handler to __libcpp_verbose_abort

[Mark de Wever via Phabricator via libcxx-commits]

Mordante accepted this revision.
Mordante added a comment.

In D130562#3687347 <https://reviews.llvm.org/D130562#3687347>, @ldionne wrote:

> In D130562#3680877 <https://reviews.llvm.org/D130562#3680877>, @Mordante wrote:
>
>> In general LGTM!
>>
>> I like the idea of using one function for all these ways to terminate the application.
>>
>> However I'm not thrilled by the name, especially the verbose part. How do you feel about `__libcpp_terminate_handler`?
>
> There is already `std::terminate_handler` which does something really different. That's one of the reasons I want to keep `handler` out of the name, because I don't want folks to get the impression that this is called when `std::abort` is called, which is not the case. Instead, it's the other way around -- this function will call `std::abort` after adding some additional information.

sounds good to me, and as said I don't want to start bikeshedding. So LGTM!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130562/new/

https://reviews.llvm.org/D130562