[libcxx-commits] [PATCH] D130541: [cmake] Dedup linker flag check polyfill

[John Ericson via Phabricator via libcxx-commits]

Ericson2314 added inline comments.


================
Comment at: compiler-rt/cmake/config-ix.cmake:197
 if(ANDROID)
-  llvm_check_compiler_linker_flag(C "-Wl,-z,global" COMPILER_RT_HAS_Z_GLOBAL)
+  llvm_check_linker_flag(C "-Wl,-z,global" COMPILER_RT_HAS_Z_GLOBAL)
   check_library_exists(log __android_log_write "" COMPILER_RT_HAS_LIBLOG)
----------------
compnerd wrote:
> Similar, `-zglobal` would be preferable IMO.
@compnerd there are some other occurences `-Wl,-z` in this file, would like them all to be plain `-z`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130541/new/

https://reviews.llvm.org/D130541