[libcxx-commits] [PATCH] D130507: [libc++] Generalize the customizeable assertion handler

[Nico Weber via Phabricator via libcxx-commits]

thakis added inline comments.


================
Comment at: libcxx/src/assert.cpp:53
+  vasprintf(&buffer, format, list);
+  android_set_abort_message(buffer);
+
----------------
thakis wrote:
> This requires API level 21. We still build for older Api levels in some configs. Can this use something that works in older Api levels?
> 
> (Also, this looks a bit unrelated to making the handler vararg?)
Ping?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130507/new/

https://reviews.llvm.org/D130507