[libcxx-commits] [PATCH] D129823: [libc++][ranges] Make range algorithms support proxy iterators

[Konstantin Varlamov via Phabricator via libcxx-commits]

var-const added a comment.

In D129823#3680764 <https://reviews.llvm.org/D129823#3680764>, @rupprecht wrote:

> Emphatic +1 to this, fixing the UB is better than hacking up libc++, and a static assert would be amazing here. I'd much rather handle a clear build breakage than spend hours/days hunting down the source of a weird runtime error.

I have added the `static_assert` to D130538 <https://reviews.llvm.org/D130538>.

In D129823#3680764 <https://reviews.llvm.org/D129823#3680764>, @rupprecht wrote:

> I am attempting to do this, although it's a little more challenging now that the failure is moved later -- it was relatively easy to provide the previous repro because the test runner crashed at the moment something went wrong; producing wrong results without crashing requires more specific knowledge of mysql internals.

I couldn't get the repro code to behave incorrectly with D130538 <https://reviews.llvm.org/D130538> patched in; it's possible that the problem is no longer in `varlen_iterator` or not in `std::sort`. So we would need a new repro case to make more progress on this.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129823/new/

https://reviews.llvm.org/D129823