[libcxx-commits] [PATCH] D130547: [libc++][ranges] Implement `ranges::is_heap{, _until}`.

Konstantin Varlamov via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Tue Jul 26 16:01:09 PDT 2022


var-const added inline comments.


================
Comment at: libcxx/include/__algorithm/is_heap.h:31
     typedef typename __comp_ref_type<_Compare>::type _Comp_ref;
-    return _VSTD::__is_heap_until<_Comp_ref>(__first, __last, __comp) == __last;
+    return std::__is_heap_until<_Comp_ref>(__first, __last, static_cast<_Comp_ref>(__comp)) == __last;
 }
----------------
huixie90 wrote:
> i think perhaps not to pass the comp_ref type explicitly since the `__is_heap_until` already takes it by reference? 
Thanks!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130547/new/

https://reviews.llvm.org/D130547



More information about the libcxx-commits mailing list